[SPARK-53808][CONNECT] Allow to pass optional JVM args to spark-connect-scala-client
#52526
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarutak
changed the title
spark-connect-scala-clientspark-connect-scala-client
pan3793
reviewed
Oct 6, 2025
| -Dio.netty.tryReflectionSetAccessible=true \ | ||
| --enable-native-access=ALL-UNNAMED" | ||
| --enable-native-access=ALL-UNNAMED \ | ||
| $JVM_ARGS" |
There was a problem hiding this comment.
should it be "SCJVM_ARGS", and document at line 34?
pan3793
approved these changes
Oct 6, 2025
hvanhovell
approved these changes
Oct 6, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes an improvement to allow to pass optionaj JVM args to
spark-connect-scala-clientthrough an environment variableSCJVM_ARGS.Why are the changes needed?
Different from other REPL tools like
spark-shell,spark-connect-scala-clientdoesn't support optional JVM args.--driver-java-optionsdoesn't affect client side.Does this PR introduce any user-facing change?
Yes but doesn't break compatibility.
How was this patch tested?
To use debugger, set
-agentlib:jdwp=transport=dt_socket,suspend=n,server=y,address=9876toSCJVM_ARGS, and I confirmed it worked.Was this patch authored or co-authored using generative AI tooling?
No.